🛡️ Sentinel: [CRITICAL] Fix SQL injection risk in JSON extraction - #148
🛡️ Sentinel: [CRITICAL] Fix SQL injection risk in JSON extraction#148Donach wants to merge 1 commit into
Conversation
Replaced insecure string concatenation via `sql.raw` in `jsonExtract` with parameterized SQL query variables cast to text (`->> (${key}::text)`), protecting against SQL injection via dynamic path evaluation.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: SQL injection risk in
jsonExtract(inpackages/core/src/db/database-wrapper.ts) viasql.raw.🎯 Impact: Attackers could inject arbitrary SQL when extracting fields via dynamically manipulated JSON paths.
🔧 Fix: Replaced
sql.rawwith parameterized Drizzlesqlqueries explicitly casting paths to text (->> (${key}::text)).✅ Verification: Ran
pnpm testandpnpm lintand both pass.PR created automatically by Jules for task 6112646420981721020 started by @Donach